[aur-dev] [PATCH] git-serve: Add out-of-date status to list-repos

Johannes Löthberg johannes at kyriasis.com
Wed Jul 29 15:47:12 UTC 2015


On 29/07, Loui Chang wrote:
>On Wed 29 Jul 2015 11:57 +0200, Lukas Fleischer wrote:
>> On Tue, 28 Jul 2015 at 18:52:20, Johannes Löthberg wrote:
>> > Signed-off-by: Johannes Löthberg <johannes at kyriasis.com>
>> > ---
>> > Note: I haven't been able to test this due to not having access to my
>> > regular laptop, but it should work.
>> >
>> >  git-interface/git-serve.py | 7 +++++--
>> >  1 file changed, 5 insertions(+), 2 deletions(-)
>> >
>> > diff --git a/git-interface/git-serve.py b/git-interface/git-serve.py
>> > index 8316cf7..2ee44dc 100755
>> > --- a/git-interface/git-serve.py
>> > +++ b/git-interface/git-serve.py
>> > @@ -47,10 +47,13 @@ def list_repos(user):
>> >      if userid == 0:
>> >          die('{:s}: unknown user: {:s}'.format(action, user))
>> >
>> > -    cur.execute("SELECT Name, PackagerUID FROM PackageBases " +
>> > +    cur.execute("SELECT Name, PackagerUID, OutOfDateTS FROM PackageBases " +
>> >                  "WHERE MaintainerUID = %s ", [userid])
>> >      for row in cur:
>> > -        print((' ' if row[1] else '*') + row[0])
>> > +        print('{empty}{outofdate}{pkgbase}'.format(
>> > +            empty=' ' if row[1] else '*',
>> > +            outofdate=' ' if row[2] else '!',
>>
>> Since it makes no sense for empty packages to be out-of-date, would it
>> be a good idea to use a 3-state flag ('*', ' ', '!') instead? Might be a
>> bad idea if we plan to add more information to that output...
>
>Why wouldn't you just print the timestamp?

Because that would make it an even worse idea if we plan on adding more 
information to the output, since it would make it even more messy, and 
not really provide much information.

-- 
Sincerely,
  Johannes Löthberg
  PGP Key ID: 0x50FB9B273A9D0BB5
  https://theos.kyriasis.com/~kyrias/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 1495 bytes
Desc: not available
URL: <https://lists.archlinux.org/pipermail/aur-dev/attachments/20150729/396b628e/attachment.asc>


More information about the aur-dev mailing list