[aur-dev] [PATCH] Fix bug with extracting sources introduced in c7203066c

Johannes Löthberg johannes at kyriasis.com
Mon Jun 8 12:18:06 UTC 2015

In c7203066ce git-update was changed to use extract_arch_fields to get
the list of sources instead of looking up them up in the pkginfo dict
manually. This was done to solve a bug where only source=() sources were
unconditionally checked for, ignoring arch-specific sources.

The extract_arch_fields function returns a list of dicts however, so we
need to extract the 'value' key from that dict before using it, which
was missed in the previous commit.

Fixes FS#45261

Signed-off-by: Johannes Löthberg <johannes at kyriasis.com>
 git-interface/git-update.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/git-interface/git-update.py b/git-interface/git-update.py
index 92953f6..4177e53 100755
--- a/git-interface/git-update.py
+++ b/git-interface/git-update.py
@@ -247,7 +247,8 @@ for commit in walker:
                 die_commit('missing %s file: %s' % (field, pkginfo[field]),
-        for fname in extract_arch_fields(pkginfo, 'source'):
+        for field in extract_arch_fields(pkginfo, 'source'):
+            fname = field['value']
             if "://" in fname or "lp:" in fname:
             if not fname in commit.tree:

More information about the aur-dev mailing list