[aur-dev] [PATCH] Add explanation for Popularity feild in search results Fixes FS#45327

Lukas Fleischer lfleischer at archlinux.org
Sun Jun 14 18:02:16 UTC 2015


s/feild/field/ in the commit message. Also, please move the "Fixes
FS#45327" to a separate paragraph.

On Sun, 14 Jun 2015 at 19:43:39, Leonidas Spyropoulos wrote:
> Signed-off-by: Leonidas Spyropoulos <artafinde at gmail.com>
> ---
>  web/template/pkg_search_results.php | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/web/template/pkg_search_results.php b/web/template/pkg_search_results.php
> index 13d9bfc..d3a1220 100644
> --- a/web/template/pkg_search_results.php
> +++ b/web/template/pkg_search_results.php
> @@ -35,7 +35,7 @@ if (!$result): ?>
>                                         <th><a href="?<?= mkurl('SB=n&SO=' . $SO_next) ?>"><?= __("Name") ?></a></th>
>                                         <th><?= __("Version") ?></th>
>                                         <th><a href="?<?= mkurl('SB=v&SO=' . $SO_next) ?>"><?= __("Votes") ?></a></th>
> -                                       <th><a href="?<?= mkurl('SB=p&SO=' . $SO_next) ?>"><?= __("Popularity") ?></a></th>
> +                                       <th><a href="?<?= mkurl('SB=p&SO=' . $SO_next) ?>"><?= __("Popularity") ?></a><a href=" " title="Popularity is calculated as the sum of all votes with each vote being weighted with a factor of 0.98 per day since its creation." style="background-color:#FFFFFF;color:#000000;text-decoration:none"><sup>?</sup></a></th>

The <span> tag also supports the title attribute, so there's no need for
this workaround. I think we might also want to add a dotted underline,
so that it is a bit clearer that there is additional information when
hovering. Please do not add inline CSS though, add a class in
web/html/css/aurweb.css instead.

Note that archweb uses a slightly different way of displaying
explanations, see the (?) link next to "Flag Package Out-of-Date" on the
details page of any official package. Maybe we want to do the same thing
for consistency?

>                                         <?php if ($SID): ?>
>                                         <th><a href="?<?= mkurl('SB=w&SO=' . $SO_next) ?>"><?= __("Voted") ?></a></th>
>                                         <th><a href="?<?= mkurl('SB=o&SO=' . $SO_next) ?>"><?= __("Notify") ?></a></th>
> -- 
> 2.4.3


More information about the aur-dev mailing list