[aur-dev] [PATCH] Wrap all confirmation checkbox labels in label tag

Johannes Löthberg johannes at kyriasis.com
Tue Jun 23 05:28:24 UTC 2015


Without a label tag around the label it won't be clickable.

Signed-off-by: Johannes Löthberg <johannes at kyriasis.com>
---
 web/html/pkgdel.php                 | 4 ++--
 web/html/pkgdisown.php              | 4 ++--
 web/html/pkgmerge.php               | 4 ++--
 web/template/account_delete.php     | 4 ++--
 web/template/pkg_search_results.php | 2 +-
 5 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/web/html/pkgdel.php b/web/html/pkgdel.php
index bad1cd3..face081 100644
--- a/web/html/pkgdel.php
+++ b/web/html/pkgdel.php
@@ -34,8 +34,8 @@ if (has_credential(CRED_PKGBASE_DELETE)): ?>
 			<?php if (isset($_GET['via'])): ?>
 			<input type="hidden" name="via" value="<?= intval($_GET['via']) ?>" />
 			<?php endif; ?>
-			<p><input type="checkbox" name="confirm" value="1" />
-			<?= __("Confirm package deletion") ?></p>
+			<p><label><input type="checkbox" name="confirm" value="1" />
+			<?= __("Confirm package deletion") ?></label></p>
 			<p><input type="submit" class="button" name="do_Delete" value="<?= __("Delete") ?>" /></p>
 		</fieldset>
 	</form>
diff --git a/web/html/pkgdisown.php b/web/html/pkgdisown.php
index 50f5c79..f7ef0f2 100644
--- a/web/html/pkgdisown.php
+++ b/web/html/pkgdisown.php
@@ -41,8 +41,8 @@ if (has_credential(CRED_PKGBASE_DISOWN, $maintainer_uids)): ?>
 			<?php if (isset($_GET['via'])): ?>
 			<input type="hidden" name="via" value="<?= intval($_GET['via']) ?>" />
 			<?php endif; ?>
-			<p><input type="checkbox" name="confirm" value="1" />
-			<?= __("Confirm to disown the package") ?></p>
+			<p><label><input type="checkbox" name="confirm" value="1" />
+			<?= __("Confirm to disown the package") ?></label</p>
 			<p><input type="submit" class="button" name="do_Disown" value="<?= __("Disown") ?>" /></p>
 		</fieldset>
 	</form>
diff --git a/web/html/pkgmerge.php b/web/html/pkgmerge.php
index a9c8894..0742c62 100644
--- a/web/html/pkgmerge.php
+++ b/web/html/pkgmerge.php
@@ -55,8 +55,8 @@ if (has_credential(CRED_PKGBASE_DELETE)): ?>
 			</script>
 			<p><label for="merge_Into" ><?= __("Merge into:") ?></label>
 			<input type="text" id="merge_Into" name="merge_Into" value="<?= isset($_GET['into']) ? $_GET['into'] : '' ?>" /></p>
-			<p><input type="checkbox" name="confirm" value="1" />
-			<?= __("Confirm package merge") ?></p>
+			<p><label><input type="checkbox" name="confirm" value="1" />
+			<?= __("Confirm package merge") ?></label></p>
 			<p><input type="submit" class="button" name="do_Delete" value="<?= __("Merge") ?>" /></p>
 		</fieldset>
 	</form>
diff --git a/web/template/account_delete.php b/web/template/account_delete.php
index 03951fe..faa0137 100644
--- a/web/template/account_delete.php
+++ b/web/template/account_delete.php
@@ -12,8 +12,8 @@
 		<input type="hidden" name="token" value="<?= htmlspecialchars($_COOKIE['AURSID']) ?>" />
 	</fieldset>
 	<fieldset>
-		<p><input type="checkbox" name="confirm" value="1" />
-		<?= __("Confirm deletion") ?></p>
+		<p><label><input type="checkbox" name="confirm" value="1" />
+		<?= __("Confirm deletion") ?></label></p>
 
 		<p>
 			<input type="submit" class="button" value="<?= __("Delete") ?>" />
diff --git a/web/template/pkg_search_results.php b/web/template/pkg_search_results.php
index 7134f2d..e866282 100644
--- a/web/template/pkg_search_results.php
+++ b/web/template/pkg_search_results.php
@@ -123,7 +123,7 @@ if (!$result): ?>
 						<label for="merge_Into"><?= __("Merge into") ?></label>
 						<input type="text" id="merge_Into" name="merge_Into" />
 					<?php endif; ?>
-					<input type="checkbox" name="confirm" value="1" /> <?= __("Confirm") ?>
+					<label><input type="checkbox" name="confirm" value="1" /> <?= __("Confirm") ?></label>
 					<input type="hidden" name="token" value="<?= htmlspecialchars($_COOKIE['AURSID']) ?>" />
 					<input type="submit" class="button" style="width: 80px" value="<?= __("Go") ?>" />
 				</p>
-- 
2.4.4


More information about the aur-dev mailing list