[aur-dev] [PATCH 3/4] git-serve: Drop direct AccountType checking, use AUR_PRIVILEGED

[Lukas Fleischer]

On Tue, 23 Jun 2015 at 00:00:20, Johannes Löthberg wrote:
> Signed-off-by: Johannes Löthberg <johannes at kyriasis.com>
> ---
>  git-interface/git-serve.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/git-interface/git-serve.py b/git-interface/git-serve.py
> index 6f521cc..2083560 100755
> --- a/git-interface/git-serve.py
> +++ b/git-interface/git-serve.py
> @@ -86,8 +86,8 @@ def check_permissions(pkgbase, user):
>                                   unix_socket=aur_db_socket, buffered=True)
>      cur = db.cursor()
>  
> -    cur.execute("SELECT AccountTypeID FROM Users WHERE UserName = %s ", [user])
> -    if cur.fetchone()[0] > 1:
> +    privileged = os.environ.get('AUR_PRIVILEGED', False)
> +    if privileged:

I think this is readable enough as a one-liner (without the extra
variable).

>          return True
>  
>      cur.execute("SELECT COUNT(*) FROM PackageBases " +
> -- 
> 2.4.4