[aur-dev] [PATCH] False 'File Request' buttons for unconfirmed users

Gordian Edenhofer gordian.edenhofer at gmail.com
Fri Jun 26 15:26:12 UTC 2015


On Fri, 2015-06-26 at 12:48 +0200, Lukas Fleischer wrote:
> On Thu, 25 Jun 2015 at 17:47:34, Gordian Edenhofer wrote:
> > [...]
> > Since FS#32481 has been fixed, does this patch will be accepted as 
> > is
> > or are there major objections?
> > [...]
> 
> I like the idea but I do not like the implementation. The package 
> base
> details and the package details pages are way too cluttered already.
> 
> I just submitted two preparatory patches to clean up at least parts 
> of
> the mess. Could you try to implement your feature on top of the pu
> branch? I didn't think of all the details but you probably don't even
> need to touch any templates. Amending the new html_action_link() and
> html_action_form() functions might be enough.
> 
> Regards,
> Lukas

The template called web/template/pkgbase_actions.php determine whether
those fields should be displayed. A simple "<?php if ($uid): ?>" is
used for this purpose. Therefore it would be necessary to alter this
file in order for users with no $uid to at least see those buttons
respectively links.
I am currently working on the implementation and will submit a new
patch pretty soon.

Best Regards,
Gordian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <https://lists.archlinux.org/pipermail/aur-dev/attachments/20150626/c4723c26/attachment.asc>


More information about the aur-dev mailing list