[aur-dev] [PATCH] Removing redundant </a> and a faulty if statement

Gordian Edenhofer gordian.edenhofer at gmail.com
Fri Jun 26 15:41:20 UTC 2015


The function html_action_link closes its link with </a> hence there
is no need for closing them again after invoking the function.
---
 web/template/pkgbase_actions.php | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/web/template/pkgbase_actions.php b/web/template/pkgbase_actions.php
index 757b063..a659c88 100644
--- a/web/template/pkgbase_actions.php
+++ b/web/template/pkgbase_actions.php
@@ -29,18 +29,18 @@
 			<?php endif; ?>
 
 			<?php if (has_credential(CRED_PKGBASE_EDIT_COMAINTAINERS, array($row["MaintainerUID"]))): ?>
-			<li><?= html_action_link($base_uri . 'comaintainers/', __('Manage Co-Maintainers')) ?></a></li>
+			<li><?= html_action_link($base_uri . 'comaintainers/', __('Manage Co-Maintainers')) ?></li>
 			<?php endif; ?>
 
 			<li><span class="flagged"><?php if ($row["RequestCount"] > 0) { echo _n('%d pending request', '%d pending requests', $row["RequestCount"]); } ?></span></li>
-			<li><?= html_action_link($base_uri . 'request/', __('File Request')) ?></a></li>
+			<li><?= html_action_link($base_uri . 'request/', __('File Request')) ?></li>
 
 			<?php if (has_credential(CRED_PKGBASE_DELETE)): ?>
-			<li><?= html_action_link($base_uri . 'delete/', __('Delete Package')) ?></a></li>
-			<li><?= html_action_link($base_uri . 'merge/', __('Merge Package')) ?></a></li>
+			<li><?= html_action_link($base_uri . 'delete/', __('Delete Package')) ?></li>
+			<li><?= html_action_link($base_uri . 'merge/', __('Merge Package')) ?></li>
 			<?php endif; ?>
 
-			<?php if ($uid && $row["MaintainerUID"] === NULL): ?>
+			<?php if ($row["MaintainerUID"] === NULL): ?>
 			<li><?= html_action_form($base_uri . 'adopt/', "do_Adopt", __('Adopt Package')) ?></li>
 			<?php elseif (has_credential(CRED_PKGBASE_DISOWN, array($row["MaintainerUID"]))): ?>
 			<li><?= html_action_form($base_uri . 'disown/', "do_Disown", __('Disown Package')) ?></li>
-- 
2.4.4


More information about the aur-dev mailing list