[aur-dev] [PATCH] Drop the message when no changes were made to an account
lfleischer at archlinux.org
Sat Jun 27 15:10:26 UTC 2015
On Sat, 27 Jun 2015 at 16:54:04, Lukas Fleischer wrote:
> On Sat, 27 Jun 2015 at 16:26:07, Johannes Löthberg wrote:
> > When no changes has been made to the account there's no need for a
> > message, and it is no longer applicable since the setting of SSH keys is
> > done in a separate function now.
> > Reported-by: Alexis Chotard <alexis.horgix.chotard at gmail.com>
> > Signed-off-by: Johannes Löthberg <johannes at kyriasis.com>
> > ---
> > web/lib/acctfuncs.inc.php | 5 +----
> > 1 file changed, 1 insertion(+), 4 deletions(-)
> > [...]
> Applied, thanks!
Just noticed that this doesn't seem to work. PDO::exec() returns false
if an error occurs and the number of modified rows otherwise. So this
results in an empty page (with just a heading) when no changes are made.
Maybe we should just replace "!$result" with "$result === false"
More information about the aur-dev