[aur-dev] [PATCH] git-update: Check for missing install and source files

Lukas Fleischer lfleischer at archlinux.org
Sun May 31 22:28:56 UTC 2015


On Mon, 01 Jun 2015 at 00:07:58, Marcel Korpel wrote:
> * Lukas Fleischer <lfleischer at archlinux.org> (Sun, 31 May 2015 22:49:19
> +0200):
> > On Sun, 31 May 2015 at 22:09:19, Marcel Korpel wrote:
> >> Nevertheless, there are other cases I didn't think of, like
> >> https://aur.archlinux.org/packages/ttf-ms-win8/ where source files
> >> should be provided by the user. Providing zero-length dummy files
> >> looks like a solution, but isn't, as the checksums provided should
> >> be correct against those user-provided files, not the dummy ones.
> >> 
> >> I can't think of a solution to this at the moment, perhaps someone
> >> else?
> > 
> > Why are checksums an issue? You can use the checksum of the correct
> > file. It doesn't match the checksum of the dummy file but I don't see
> > how that is an issue (it is even good since the user immediately
> > notices that something is wrong with the dummy file). Another
> > possibility is to tell makepkg to skip the integrity check.
> 
> Isn't there a check of checksums before files are added to the index
> (through mksrcinfo/makepkg)? If that's not the case, I stand corrected.
> 
> 

Right, I forgot about that. So the two possibilities left are

(a) Build the package using the original files, replace with dummy files
    before committing.

(b) Use "SKIP" for the checksums.

I realize that (a) might be a bit cumbersome but then again, users
currently need to fix their source tarballs manually after running
`makepkg --source` (and remove some source files) which is cumbersome as
well.


More information about the aur-dev mailing list