[aur-dev] [PATCH] Unset $pinned unconditionally when displaying comments

Lukas Fleischer lfleischer at archlinux.org
Tue Feb 16 17:13:13 UTC 2016

On Tue, 16 Feb 2016 at 14:21:55, Mark Weiman wrote:
> Signed-off-by: Mark Weiman <mark.weiman at markzz.com>
> ---
>  web/lib/pkgbasefuncs.inc.php | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> [...]

Added this to my patch queue with the following more detailed commit

    Unset $pinned unconditionally when displaying comments

    In pkg_comments.php, the $pinned variable is used to determine whether
    the template is supposed to print all comments or pinned comments only.
    If the $pinned variable is unset, the top 10 comments are printed,
    followed by an "All comments" link. If the $pinned variable is set, the
    pinned comments are printed and the "All comments" link below the
    comment listing is skipped. Thus, we need to make sure that this
    variable is always unset at the time we include the template to display
    all comments, even if it was empty before.

    Fixes FS#48194.


More information about the aur-dev mailing list