[aur-dev] [PATCH v3] Fixup for missing changes in 6ec4a3589

Johannes Löthberg johannes at kyriasis.com
Wed Jun 22 21:24:24 UTC 2016


Commit 6ec4a3589 forgot to change the usages of the display_account_form
and process_account_form function to account for the new parameter, and
forgot to add the new column to aur-schema.sql.

Signed-off-by: Johannes Löthberg <johannes at kyriasis.com>
---
Added some more missing arguments.  With this patch the homepage patch 
on pu works.

 schema/aur-schema.sql |  1 +
 web/html/account.php  |  9 ++++++---
 web/html/register.php | 45 +++++++++++++++++++++++++++++++++++++--------
 3 files changed, 44 insertions(+), 11 deletions(-)

diff --git a/schema/aur-schema.sql b/schema/aur-schema.sql
index 7edf94c..1affc25 100644
--- a/schema/aur-schema.sql
+++ b/schema/aur-schema.sql
@@ -41,6 +41,7 @@ CREATE TABLE Users (
 	RegistrationTS TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP,
 	CommentNotify TINYINT(1) NOT NULL DEFAULT 1,
 	UpdateNotify TINYINT(1) NOT NULL DEFAULT 0,
+	OwnershipNotify TINYINT(1) NOT NULL DEFAULT 1,
 	PRIMARY KEY (ID),
 	UNIQUE (Username),
 	UNIQUE (Email),
diff --git a/web/html/account.php b/web/html/account.php
index 8d92b2c..2892f04 100644
--- a/web/html/account.php
+++ b/web/html/account.php
@@ -34,9 +34,10 @@ if ($action == "UpdateAccount") {
 			in_request("U"), in_request("T"), in_request("S"),
 			in_request("E"), in_request("H"), in_request("P"),
 			in_request("C"), in_request("R"), in_request("L"),
-			in_request("I"), in_request("K"), in_request("PK"),
-			in_request("J"), in_request("CN"), in_request("UN"),
-			in_request("ID"), $row["Username"]);
+			in_request("HP"), in_request("I"), in_request("K"),
+			in_request("PK"), in_request("J"), in_request("CN"),
+			in_request("UN"), in_request("ON"), in_request("ID"),
+			$row["Username"]);
 	}
 }
 
@@ -95,6 +96,7 @@ if (isset($_COOKIE["AURSID"])) {
 					$row["InactivityTS"] ? 1 : 0,
 					$row["CommentNotify"],
 					$row["UpdateNotify"],
+					$row["OwnershipNotify"],
 					$row["ID"],
 					$row["Username"]);
 			} else {
@@ -146,6 +148,7 @@ if (isset($_COOKIE["AURSID"])) {
 				in_request("J"),
 				in_request("CN"),
 				in_request("UN"),
+				in_request("ON"),
 				in_request("ID"),
 				$row["Username"]);
 		}
diff --git a/web/html/register.php b/web/html/register.php
index 3155449..6c6d52e 100644
--- a/web/html/register.php
+++ b/web/html/register.php
@@ -20,18 +20,47 @@ echo '<h2>' . __('Register') . '</h2>';
 
 if (in_request("Action") == "NewAccount") {
 	list($success, $message) = process_account_form(
-			"new", "NewAccount", in_request("U"), 1, 0,
-			in_request("E"), in_request("H"), '', '', in_request("R"),
-			in_request("L"), in_request("I"), in_request("K"),
-			in_request("PK"), 0, in_request("CN"), in_request("UN"));
+		"new",
+		"NewAccount",
+		in_request("U"),
+		1,
+		0,
+		in_request("E"),
+		in_request("H"),
+		'',
+		'',
+		in_request("R"),
+		in_request("L"),
+		in_request("HP"),
+		in_request("I"),
+		in_request("K"),
+		in_request("PK"),
+		0,
+		in_request("CN"),
+		in_request("UN"),
+		in_request("ON"));
 
 	print $message;
 
 	if (!$success) {
-		display_account_form("NewAccount", in_request("U"), 1, 0,
-			in_request("E"), in_request("H"), '', '', in_request("R"),
-			in_request("L"), in_request("I"), in_request("K"),
-			in_request("PK"), 0, in_request("CN"), in_request("UN"));
+		display_account_form("NewAccount",
+			in_request("U"),
+			1,
+			0,
+			in_request("E"),
+			in_request("H"),
+			'',
+			'',
+			in_request("R"),
+			in_request("L"),
+			in_request("HP"),
+			in_request("I"),
+			in_request("K"),
+			in_request("PK"),
+			0,
+			in_request("CN"),
+			in_request("UN"),
+			in_request("ON"));
 	}
 } else {
 	print '<p>' . __("Use this form to create an account.") . '</p>';
-- 
2.9.0


More information about the aur-dev mailing list