[aur-dev] [PATCH] notify: Fix check for 0 when sending req close notification

Lukas Fleischer lfleischer at archlinux.org
Thu Jun 30 20:45:22 UTC 2016


On Thu, 30 Jun 2016 at 20:45:53, Johannes Löthberg via aur-dev wrote:
> 528bf84 (Distinguish auto-accepted requests, 2016-06-30) reimplemented
> sending the message saying that the request was automatically accepted,
> but checks if the uid argument is false.  The argument passed from PHP
> when a user didn't manually accept the request is '0' though, causing
> the request to not be sent properly.
> 
> Signed-off-by: Johannes Löthberg <johannes at kyriasis.com>
> ---
>  scripts/notify.py | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)

Thanks. The original patch is on pu and has not even been submitted to
the mailing list yet, for those who wonder. I squashed the following
simpler patch into it:

-- 8< --
diff --git a/scripts/notify.py b/scripts/notify.py
index ac02a01..6ea25d1 100755
--- a/scripts/notify.py
+++ b/scripts/notify.py
@@ -385,7 +385,7 @@ def request_close(cur, uid, reqid, reason):
     text = get_request_closure_comment(cur, reqid)
 
     subject = '[PRQ#%d] Request %s' % (int(reqid), reason.title())
-    if uid:
+    if int(uid):
         user = username_from_id(cur, uid)
         user_uri = aur_location + '/account/' + user + '/'
         body = 'Request #%d has been %s by %s [1]' % (int(reqid), reason, user)
-- >8 --


More information about the aur-dev mailing list