[aur-dev] [PATCH 2/2] aurjson: Remove stray GROUP BY clause

Lukas Fleischer lfleischer at archlinux.org
Tue Mar 1 17:38:15 UTC 2016


The IDs of packages are unique, so there is no need to group search
results by package ID.

Note that the GROUP BY statement in question was introduced in commit
3447dfc (Support versioned RPC queries, 2014-04-28) for no apparent
reason and could even lead to errors in various DBMS.

Signed-off-by: Lukas Fleischer <lfleischer at archlinux.org>
---
 web/lib/aurjson.class.php | 1 -
 1 file changed, 1 deletion(-)

diff --git a/web/lib/aurjson.class.php b/web/lib/aurjson.class.php
index 7f9b5f2..3bd9179 100644
--- a/web/lib/aurjson.class.php
+++ b/web/lib/aurjson.class.php
@@ -266,7 +266,6 @@ class AurJSON {
 				"ON Licenses.ID = PackageLicenses.LicenseID " .
 				"WHERE ${where_condition} " .
 				"AND PackageBases.PackagerUID IS NOT NULL " .
-				"GROUP BY Packages.ID " .
 				"LIMIT $max_results";
 		} elseif ($this->version >= 2) {
 			if ($this->version == 2 || $this->version == 3) {
-- 
2.7.2


More information about the aur-dev mailing list