[aur-dev] [PATCH v2 2/2] Fix DB.class.php to match config and include SQLite support

Mark Weiman mark.weiman at markzz.com
Wed Nov 9 23:54:38 UTC 2016


In commit baf8a22 (git-interface: Support SQLite as database backend,
2016-08-03), conf/config.proto was changed so that dsn_prefix was
changed to backend and this fixes this in web/lib/DB.class.php.

Since SQLite's dsn is different, this adds a check of which backend is
desired and will quit if MySQL or SQLite are not the backend selected.
SQLite2 may be supported, but is untested and will trigger an error if
used.

Signed-off-by: Mark Weiman <mark.weiman at markzz.com>
---
 web/lib/DB.class.php | 24 +++++++++++++++++-------
 1 file changed, 17 insertions(+), 7 deletions(-)

diff --git a/web/lib/DB.class.php b/web/lib/DB.class.php
index b538e0d..dfdbbf9 100644
--- a/web/lib/DB.class.php
+++ b/web/lib/DB.class.php
@@ -17,20 +17,30 @@ class DB {
 	public static function connect() {
 		if (self::$dbh === null) {
 			try {
-				$dsn_prefix = config_get('database', 'dsn_prefix');
+				$backend = config_get('database', 'backend');
 				$host = config_get('database', 'host');
 				$socket = config_get('database', 'socket');
 				$name = config_get('database', 'name');
 				$user = config_get('database', 'user');
 				$password = config_get('database', 'password');
 
-				$dsn = $dsn_prefix .
-				       ':host=' . $host .
-				       ';unix_socket=' . $socket .
-				       ';dbname=' . $name;
+				if ($backend == "mysql") {
+					$dsn = $backend .
+						':host=' . $host .
+						';unix_socket=' . $socket .
+						';dbname=' . $name;
+
+					self::$dbh = new PDO($dsn, $user, $password);
+					self::$dbh->exec("SET NAMES 'utf8' COLLATE 'utf8_general_ci';");
+				} else if ($backend == "sqlite") {
+					$dsn = $backend .
+						":" . $name;
+
+					self::$dbh = new PDO($dsn, null, null);
+				} else {
+					die("Error - " . $backend . " is not supported by aurweb");
+				}
 
-				self::$dbh = new PDO($dsn, $user, $password);
-				self::$dbh->exec("SET NAMES 'utf8' COLLATE 'utf8_general_ci';");
 			} catch (PDOException $e) {
 				die('Error - Could not connect to AUR database');
 			}
-- 
2.10.2


More information about the aur-dev mailing list