[aur-dev] [PATCH 2/2] schema: Fix invalid NULL on primary key

Florian Pritz bluewind at xinu.at
Sat Apr 15 18:31:38 UTC 2017


>From the mysql 5.7 breaking change page:

Columns in a PRIMARY KEY must be NOT NULL, but if declared explicitly as
NULL produced no error. Now an error occurs. For example, a statement
such as CREATE TABLE t (i INT NULL PRIMARY KEY) is rejected. The same
occurs for similar ALTER TABLE statements. (Bug #13995622, Bug #66987,
Bug #15967545, Bug #16545198)

References:
http://stackoverflow.com/a/22314073

Signed-off-by: Florian Pritz <bluewind at xinu.at>
---
 schema/aur-schema.sql | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/schema/aur-schema.sql b/schema/aur-schema.sql
index b3e4ecb..89167b3 100644
--- a/schema/aur-schema.sql
+++ b/schema/aur-schema.sql
@@ -373,7 +373,7 @@ CREATE TABLE IF NOT EXISTS TU_Votes (
 -- Malicious user banning
 --
 CREATE TABLE Bans (
-	IPAddress VARCHAR(45) NULL DEFAULT NULL,
+	IPAddress VARCHAR(45) NOT NULL,
 	BanTS TIMESTAMP NOT NULL,
 	PRIMARY KEY (IPAddress)
 ) ENGINE = InnoDB;
-- 
2.12.2


More information about the aur-dev mailing list