[aur-dev] [PATCH 2/4] Check query return value in search_results_page()

Lukas Fleischer lfleischer at archlinux.org
Tue Apr 18 06:52:52 UTC 2017


Instead of unconditionally calling fetch on the return value of query(),
error out early if the value evaluates to false. Also, make sure that
the results array is always initialized, even if the result set is
empty.

Signed-off-by: Lukas Fleischer <lfleischer at archlinux.org>
---
 web/lib/acctfuncs.inc.php | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/web/lib/acctfuncs.inc.php b/web/lib/acctfuncs.inc.php
index 3c8f9ed..22b3ca8 100644
--- a/web/lib/acctfuncs.inc.php
+++ b/web/lib/acctfuncs.inc.php
@@ -495,8 +495,11 @@ function search_results_page($O=0,$SB="",$U="",$T="",
 
 	$result = $dbh->query($q);
 
-	while ($row = $result->fetch(PDO::FETCH_ASSOC)) {
-		$userinfo[] = $row;
+	$userinfo = array();
+	if ($result) {
+		while ($row = $result->fetch(PDO::FETCH_ASSOC)) {
+			$userinfo[] = $row;
+		}
 	}
 
 	include("account_search_results.php");
-- 
2.12.2


More information about the aur-dev mailing list