[aur-dev] [PATCH] t1300: Fix test cases for non-fast-forward pushes

Lukas Fleischer lfleischer at archlinux.org
Tue Aug 8 13:32:02 UTC 2017


Since commit c5302d3 (Require TUs to explicitly request to overwrite a
pkgbase, 2017-07-24), non-fast-forward pushes are denied even for
Trusted Users, unless the AUR_OVERWRITE environment variable is set.
Mark the test case performing a non-fast-forward push from a TU
account as test_must_fail and add another test case performing the
same operation with AUR_OVERWRITE=1.

Signed-off-by: Lukas Fleischer <lfleischer at archlinux.org>
---
 test/t1300-git-update.sh | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/test/t1300-git-update.sh b/test/t1300-git-update.sh
index f16e2ad..109351a 100755
--- a/test/t1300-git-update.sh
+++ b/test/t1300-git-update.sh
@@ -125,7 +125,18 @@ test_expect_success 'Performing a non-fast-forward ref update.' '
 test_expect_success 'Performing a non-fast-forward ref update as Trusted User.' '
 	old=$(git -C aur.git rev-parse HEAD) &&
 	new=$(git -C aur.git rev-parse HEAD^) &&
+	cat >expected <<-EOD &&
+	error: denying non-fast-forward (you should pull first)
+	EOD
 	AUR_USER=tu AUR_PKGBASE=foobar AUR_PRIVILEGED=1 \
+	test_must_fail "$GIT_UPDATE" refs/heads/master "$old" "$new" 2>&1 &&
+	test_cmp expected actual
+'
+
+test_expect_success 'Performing a non-fast-forward ref update with AUR_OVERWRITE=1.' '
+	old=$(git -C aur.git rev-parse HEAD) &&
+	new=$(git -C aur.git rev-parse HEAD^) &&
+	AUR_USER=tu AUR_PKGBASE=foobar AUR_PRIVILEGED=1 AUR_OVERWRITE=1 \
 	"$GIT_UPDATE" refs/heads/master "$old" "$new" 2>&1
 '
 
-- 
2.14.0


More information about the aur-dev mailing list