[aur-dev] [PATCH] pkgbase.php: Squelch PHP warning

Lukas Fleischer lfleischer at archlinux.org
Tue Feb 28 06:14:41 UTC 2017


Signed-off-by: Lukas Fleischer <lfleischer at archlinux.org>
---
 web/html/pkgbase.php | 32 +++++++++++++++++++-------------
 1 file changed, 19 insertions(+), 13 deletions(-)

diff --git a/web/html/pkgbase.php b/web/html/pkgbase.php
index 23aa6c8..ab40984 100644
--- a/web/html/pkgbase.php
+++ b/web/html/pkgbase.php
@@ -145,17 +145,21 @@ if (check_token()) {
 	}
 }
 
-$pkgs = pkgbase_get_pkgnames($base_id);
-if (!$output && count($pkgs) == 1) {
-	/* Not a split package. Redirect to the package page. */
-	if (empty($_SERVER['QUERY_STRING'])) {
-		header('Location: ' . get_pkg_uri($pkgs[0]) . $fragment);
-	} else {
-		header('Location: ' . get_pkg_uri($pkgs[0]) . '?' . $_SERVER['QUERY_STRING'] . $fragment);
+if (isset($base_id)) {
+	$pkgs = pkgbase_get_pkgnames($base_id);
+	if (!$output && count($pkgs) == 1) {
+		/* Not a split package. Redirect to the package page. */
+		if (empty($_SERVER['QUERY_STRING'])) {
+			header('Location: ' . get_pkg_uri($pkgs[0]) . $fragment);
+		} else {
+			header('Location: ' . get_pkg_uri($pkgs[0]) . '?' . $_SERVER['QUERY_STRING'] . $fragment);
+		}
 	}
-}
 
-$details = pkgbase_get_details($base_id);
+	$details = pkgbase_get_details($base_id);
+} else {
+	$details = array();
+}
 html_header($title, $details);
 ?>
 
@@ -169,10 +173,12 @@ html_header($title, $details);
 
 <?php
 include('pkg_search_form.php');
-if (isset($_COOKIE["AURSID"])) {
-	pkgbase_display_details($base_id, $details, $_COOKIE["AURSID"]);
-} else {
-	pkgbase_display_details($base_id, $details, null);
+if (isset($base_id)) {
+	if (isset($_COOKIE["AURSID"])) {
+		pkgbase_display_details($base_id, $details, $_COOKIE["AURSID"]);
+	} else {
+		pkgbase_display_details($base_id, $details, null);
+	}
 }
 
 html_footer(AURWEB_VERSION);
-- 
2.12.0


More information about the aur-dev mailing list