[aur-dev] [PATCH v7 1/3] Add user set timezones

Lukas Fleischer lfleischer at archlinux.org
Fri Jan 20 22:25:14 UTC 2017


On Fri, 20 Jan 2017 at 07:16:39, Mark Weiman wrote:
> Currently, aurweb displays all dates and times in UTC time. This patch
> adds a capability for each logged in user to set their preferred
> timezone.
> 
> Signed-off-by: Mark Weiman <mark.weiman at markzz.com>
> ---
> Removed renegade random tab in aur.inc.php
> Changed comment for set_tz() to not mention global $TZ that was removed
> Renamed $TZ in set_tz() to $timezone
> Change fetchAll() to fetchColumn() in set_tz()
> Removed extraneous else branch in set_tz()
> Simplified timezone check in set_tz()
> Moved if block from account_edit_form.php to display_account_form() before inclusion
>  conf/config.proto                    |  1 +
>  schema/aur-schema.sql                |  1 +
>  upgrading/4.5.0.txt                  |  5 +++
>  web/html/account.php                 |  3 ++
>  web/html/register.php                |  2 ++
>  web/html/voters.php                  |  2 +-
>  web/lib/acctfuncs.inc.php            | 27 +++++++++++++---
>  web/lib/aur.inc.php                  |  3 ++
>  web/lib/pkgreqfuncs.inc.php          |  2 +-
>  web/lib/timezone.inc.php             | 60 ++++++++++++++++++++++++++++++++++++
>  web/template/account_edit_form.php   | 15 +++++++++
>  web/template/flag_comment.php        |  2 +-
>  web/template/pkg_comments.php        |  6 ++--
>  web/template/pkg_details.php         |  6 ++--
>  web/template/pkgbase_details.php     |  6 ++--
>  web/template/pkgreq_results.php      |  2 +-
>  web/template/stats/updates_table.php |  2 +-
>  web/template/tu_details.php          |  4 +--
>  web/template/tu_list.php             |  4 +--
>  19 files changed, 130 insertions(+), 23 deletions(-)
>  create mode 100644 upgrading/4.5.0.txt
>  create mode 100644 web/lib/timezone.inc.php
> [...]

This looks all good to me now. I added a reference to FS#48729 to the
commit message and merged the result to pu. There was a small merge
conflict but everything should be fine.

Thanks for working on this and thanks for all those rerolls!


More information about the aur-dev mailing list