[PATCH] Make delete and merge links create an auto-accepted request
eschwartz at archlinux.org
Sun Dec 23 21:58:03 UTC 2018
On 12/23/18 4:14 PM, Johannes Löthberg wrote:
> This lets us have a better paper-trail over what happens in the AUR.
I'm opposed to this change.
The purpose of those links is arguably to do things in exceptional
circumstances. There are cases where an auto-accepted request is simply
uninteresting information. e.g., the following cases:
- user submits deletion request, Eli Schwartz uses "close" instead of
"accept", with the message "merged instead". Do we really need
additional notifications here?
- deletion of spam packages
Moreover, the current proposal is simply inferior in every possible way
compared to simply submitting a request, then accepting it. That way you
get to leave a message saying why it happened... I would simply never
ever use the delete/merge links if I actually wanted to send out
On top of this, where is the notification for orphaning packages against
the will of the maintainer?
It's basically accepted practice regardless that when TUs adopt a
package into community, they submit a deletion request and then accept
it. This will traditionally include the high-content comment "moved to
The current patchset was proposed in response to one TU on IRC, who
feels strongly about the goal of said paper trail and desired to have
the entire feature removed from aurweb altogether. I propose instead
that we follow my recommendation to document on the wiki at
TUs should submit a deletion request *with the relevant comment* rather
than deleting the package.
I see no reason to modify the emergency override tools. I'm unaware of
the lack of a paper trail being a significant issue. Perhaps we should
just trust each TU in good faith that the reason we elected them is
because they're not going to misuse the tools?
Note: regarding the person who suggested on IRC that the links should be
removed, the orphan link in particular is utterly crucial to remain,
since aurweb includes a feature to accept an orphan request early by
leaving a comment and *not* actually orphaning the package. This
requires the TU to manually use the orphan link. If orphan requests were
given fair treatment with the other two request types, this would result
in a second notification every time it was used.
More generally, if you wish to leave a comment in the acceptance
notification, you must use the same comment form followed by manual
followup when closing a deletion or merge request as well (although
those are not locked for the duration of a 14-day grace period).
tl;dr this is a documentation problem, not a code problem. It is also
not a practical problem, since we're supposedly already doing the
preferred method... right?
Bug Wrangler and Trusted User
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 833 bytes
Desc: OpenPGP digital signature
More information about the aur-dev