[PATCH v2] Add page for seeing all of a user's comments

Lukas Fleischer lfleischer at archlinux.org
Sun Jul 22 08:15:56 UTC 2018


On Tue, 17 Jul 2018 at 14:31:26, Johannes Löthberg wrote:
> Signed-off-by: Johannes Löthberg <johannes at kyriasis.com>
> ---
> v2: Actually add the new template, d'oh.
> 
>  web/html/account.php               |  69 +++++++++++++++-
>  web/html/css/aurweb.css            |  17 ++++
>  web/html/index.php                 |   2 +
>  web/html/pkgbase.php               |   7 +-
>  web/lib/acctfuncs.inc.php          |  41 ++++++++++
>  web/lib/credentials.inc.php        |   2 +
>  web/template/account_comments.php  | 125 +++++++++++++++++++++++++++++
>  web/template/account_edit_form.php |   1 +
>  8 files changed, 261 insertions(+), 3 deletions(-)
>  create mode 100644 web/template/account_comments.php
> [...]

Thanks a lot for implementing this!

There is a lot of code duplication going on, though. Is there any reason
we cannot use a shared template for the package comments and the user
comments pages? It seems like one only needs to choose a different
result set?

Best regards,
Lukas


More information about the aur-dev mailing list