[PATCH] feat(rpc): return "providers" packages when querying by `name` or `name-desc`

Eli Schwartz eschwartz at archlinux.org
Tue Mar 20 18:56:46 UTC 2018

On 03/20/2018 02:36 PM, Lukas Fleischer wrote:
> On Tue, 20 Mar 2018 at 05:49:57, morganamilo wrote:
>> From: actionless <actionless.loveless at gmail.com>
>> ---
>>  doc/rpc.txt               |  4 ++--
>>  web/lib/aurjson.class.php | 16 +++++++++++++++-
>>  2 files changed, 17 insertions(+), 3 deletions(-)
>> [...]
> Thank you for submitting a patch! Before commenting on implementation
> details, I would like to discuss the overall approach, though. What is
> the rationale for making it part of name and name-desc? Wouldn't it make
> more sense to add a new search type ("providers")?

Well, we have no precedent here as archweb does not allow searching by
provides either AFAICT. But I think, generally speaking, from a
usability perspective any search that is not an exact-name search is
probably *interested* in these provides packages.

pacman -Ss will show them, pacman -S will install them, so the web
interfaces arguably should do the same.


Aside: that commit message feels somewhat jarring as it does not match
the (admittedly loose) style in use. I have no idea why this commit is a
"feat" but it feels oddly self-congratulatory, as though the commit is a
circus performer demonstrating a trick.

Am I missing out on the latest fashion or something?

Eli Schwartz
Bug Wrangler and Trusted User

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.archlinux.org/pipermail/aur-dev/attachments/20180320/91d01b8e/attachment.asc>

More information about the aur-dev mailing list