[PATCH v2] pkg_comments.php: Make comment timestamps link to the comment

Eli Schwartz eschwartz at archlinux.org
Wed Oct 17 01:56:35 UTC 2018


On 10/16/18 9:31 PM, Vladimir Panteleev wrote:
> As of today, there is no easy way to obtain a link to a specific
> comment on a package page.
> 
> Many implementations of forums and comment systems today seem to
> follow a convention where a comment's timestamp is an unobtrusive link
> to the comment itself. Some examples are:
> 
> - phpBB (e.g. bbs.archlinux.org)
> - GitHub
> - Disqus
> - Discourse
> 
> This patch adopts this convention as well, by making the timestamp a
> link to the comment.
> ---
> 
> Version 2: Removed the CSS rule making the link color same as the
> text, thus making the link more discoverable.

Thanks, the change looks great! Tested locally and it performs as expected.

...

As discussed on IRC, there doesn't seem to be any specific motivation to
add the CSS rule other than "preserve the status quo" w.r.t. coloring,
but I think it's reasonable to make it stand out, and this matches what
I've seen on many other websites, so, merged to pu.

-- 
Eli Schwartz
Bug Wrangler and Trusted User

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.archlinux.org/pipermail/aur-dev/attachments/20181016/bdd36ef7/attachment.asc>


More information about the aur-dev mailing list