[PATCH] pkgreqfuncs: Don't leave out non-default ClosureComment column

Eli Schwartz eschwartz at archlinux.org
Tue Jul 30 18:21:22 UTC 2019

On 7/30/19 1:46 PM, Johannes Löthberg wrote:
> Since 09cb61a (schema: Remove invalid default values for TEXT columns,
> 2017-04-15) the PackageRequests.ClosureComment field no longer has a
> default value.

Hotfixed by lfleischer and now people can submit requests once more.

One would think it would be nice to have default values, but apparently
only expressions can be default values for TEXT, and expressions, meanwhile,
- are only supported for some storage engines, and
- only available in mysql >= 8.0.13

Hopefully none of the other fields that dropped their defaults in commit
09cb61a will ever have an assumed default used. I think all the others
should need user input stored when first adding the row, which is fine...

Eli Schwartz
Bug Wrangler and Trusted User

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 1601 bytes
Desc: OpenPGP digital signature
URL: <https://lists.archlinux.org/pipermail/aur-dev/attachments/20190730/df6f436e/attachment.sig>

More information about the aur-dev mailing list