[PATCH] Display warning when flagging VCS packages

[Lukas Fleischer]

On Sat, 25 May 2019 at 13:46:45, Bruno Pagani wrote:
> Le 25/05/2019 =C3=A0 19:07, Lukas Fleischer a =C3=A9crit=C2=A0:
> > +             This is a VCS package. Please do <strong>not</strong> fla=
g this package out-of-date when the package version in the AUR does not mat=
ch the most recent commit.
>=20
> Maybe we should also hint when it is appropriated to do so? E.g. missing
> new dependency or old one to be removed, moved upstream=E2=80=A6

There already is a message stating that package flagging should not be
used to report such bugs. Is it not obvious/precise enough?

>=20
> > +/**
> > + * Determine whether a package base is (or contains a) VCS package
> > + *
> > + * @param int $base_id The ID of the package base
> > + *
> > + * @return bool True if the package base is/contains a VCS package
> > + */
> > +function pkgbase_is_vcs($base_id) {
> > +     $suffixes =3D array("-cvs", "-svn", "-git", "-hg", "-bzr", "-darc=
s");
>=20
> What about false positives and missing items like -nightly=E2=80=99s? I t=
hink it
> would be a good time to implement FS#56602, auto-seed the value
> depending on your above list and let maintainers override this.

Yes, there are false positives and false negatives. That is why we only
display a warning and do not automatically disable the feature for VCS
packages. Read the comments in FS#62733 for details.