[PATCH] First HTTP functional test of the RPC interface
lfleischer at archlinux.org
Wed Apr 15 12:08:08 UTC 2020
On Tue, 14 Apr 2020 at 09:49:06, Frédéric Mangano-Tarumi wrote:
> My bad, you\u2019re right. I had changed it following the TESTING
> instructions. aur_location is clearly the variable to use, but in the
> current state some people will miss it and the test suite would send
> requests to production. One more argument in favor of the self-contained
> test suite.
Our test suite already uses a separate configuration which is
auto-generated in test/setup.sh, so it is already self-contained in that
sense; we only need to update aur_location there.
> > We should still try to keep the tests that require these preparatory
> > steps separate from tests that don't, just in case anybody wants to run
> > the tests without having to install all the additional components.
> Easy enough. We can spawn the server on the first instantiation of the
> test client fixture. We could add some more detection steps to mark the
> tests as skipped if spawning fails because of missing dependencies.
Great! I would probably prefer having a simple way of telling the test
suite to run with or without these tests, though. We should not let the
test suite pass if we intended to run all tests but forgot to install
some dependency. Maybe we can use an environment variable for that?
More information about the aur-dev