[PATCH] Exclude suspended Users from being notified

Frédéric Mangano-Tarumi fmang at mg0.fr
Mon Jul 13 14:47:03 UTC 2020


Hi Kevin,

Kevin Morris [2020-07-03 18:29:16 -0700]
> diff --git a/aurweb/scripts/notify.py b/aurweb/scripts/notify.py
> index 5b18a476..223ed61f 100755
> --- a/aurweb/scripts/notify.py
> +++ b/aurweb/scripts/notify.py
> @@ -171,7 +171,8 @@ class CommentNotification(Notification):
>                             'ON PackageNotifications.UserID = Users.ID WHERE ' +
>                             'Users.CommentNotify = 1 AND ' +
>                             'PackageNotifications.UserID != ? AND ' +
> -                           'PackageNotifications.PackageBaseID = ?',
> +                           'PackageNotifications.PackageBaseID = ? AND ' +
> +                           'Users.Suspended = 0' +,

In that last line, `+,` is not a valid Python syntax. The test suite is
screaming.

Since you’re a new contributor, you might want to read `test/README.md`
and `CONTRIBUTING.md` to prevent these little errors.

Regards,
-- 
fmang


More information about the aur-dev mailing list