[PATCH] aurweb.l10n: Translate without side effects

Frédéric Mangano-Tarumi fmang at mg0.fr
Tue Jun 9 18:25:22 UTC 2020


The install method in Python’s gettext API aliases the translator’s
gettext method to an application-global _(). We don’t use that anywhere,
and it’s clear from aurweb’s Translator interface that we want to
translate a piece of text without affecting any global namespace.
---
 aurweb/l10n.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/aurweb/l10n.py b/aurweb/l10n.py
index 492200b3..51b56abb 100644
--- a/aurweb/l10n.py
+++ b/aurweb/l10n.py
@@ -15,5 +15,4 @@ class Translator:
             self._translator[lang] = gettext.translation("aurweb",
                                                          self._localedir,
                                                          languages=[lang])
-        self._translator[lang].install()
-        return _(s)  # _ is not defined, what is this?  # noqa: F821
+        return self._translator[lang].gettext(s)
-- 
2.27.0


More information about the aur-dev mailing list