[PATCH] First HTTP functional test of the RPC interface

Frédéric Mangano-Tarumi fmang at mg0.fr
Sat May 23 16:58:32 UTC 2020


Lukas Fleischer [2020-05-23 12:35:46 -0400]
> On Sun, 12 Apr 2020 at 12:55:46, Frédéric Mangano-Tarumi wrote:
> > ---
> >  aurweb/test/__init__.py |  0
> >  aurweb/test/conftest.py | 51 +++++++++++++++++++++++++++++++++++++++++
> >  aurweb/test/test_rpc.py | 21 +++++++++++++++++
> >  aurweb/test/wsgihttp.py | 38 ++++++++++++++++++++++++++++++
> >  test/README.md          |  3 +++
> >  test/rpc.t              |  2 ++
> 
> This currently seems to break our tests:
> 
>     configparser.NoSectionError: No section: 'database'

This is the version that requires an AUR instance running, and also
AUR_CONFIG to be set to that instance’s config. Note that you need to
set aur_location accordingly too.

The fix consists in making the test suite spawn its own test instance,
as we talked about earlier. Like you suggested, we should also move it
in a separate test directory so that it won’t get triggered by default.

I submitted this patch when we were considering porting the whole
PHP code base to Python. However, if we instead port the code as we make
new features, then the new framework would provide testing tools without
requiring us to prepare and run a dual-stack instance. Functional HTTP
testing won’t be as useful.

I suggest we put this patch on the back burner until we gather the will
manpower to intensively port the code with the intention of keeping its
behavior intact.


More information about the aur-dev mailing list