[aur-general] Quality

[Magnus Therning]

On Mon, Aug 23, 2010 at 09:50, Nathan O <ndowens.aur at gmail.com> wrote:
> Random: http://aur.archlinux.org/packages/coffeearc/coffeearc/PKGBUILD

:-)

So is your request for someone to look at any of the packages
maintained by the user ndowens?

Here are my comments on coffeearc:

# Contributor: Nathan Owe <ndowens04 at gmail>
pkgname=coffeearc
pkgver=0_60a
pkgrel=1
pkgdesc="java zip/other format archiver"

 -- This description can probably be improved somewhat.  Looking at the
 upstream page it's described like this:

 "Coffeearc is a simple, extensible GUI archiver that interfaces with
 file-to-file command-line compression tools or special plugins which use the
 Coffeearc API."

 Maybe something like "Multi-format GUI archiver"?

arch=('any')
url="http://forge.simplana.de/projects/show/coffeearc"
license=('gpl')
depends=('java-runtime' 'bash')

 -- is bash really a dependency, or would sh be enough?

source=(http://forge.simplana.de/attachments/download/15/Coffeearc_$pkgver.zip)

 -- this link gives me a 404
 -- coffeearc.sh should be among the sources

noextract=(*.jar)
md5sums=('f3eab83a95175a3381679aab081e5d20')

build() {
cd $srcdir/Coffeearc_$pkgver
install -d $pkgdir/usr/share/java/$pkgname $pkgdir/usr/bin || return 1
cp -rf libs profiles plugin.mf coffeearc.mf
$pkgdir/usr/share/java/$pkgname || return 1
install -m755 coffeearc.jar
$pkgdir/usr/share/java/$pkgname/coffeearc.jar || return 1
install -m755 $startdir/coffeearc.sh $pkgdir/usr/bin/coffeearc

}

# vim:set ts=2 sw=2 et:

/M

-- 
Magnus Therning                        (OpenPGP: 0xAB4DFBA4)
magnus＠therning．org          Jabber: magnus＠therning．org
http://therning.org/magnus         identi.ca|twitter: magthe