[aur-general] Review my PKGBUILDs

[Vojtech Horky]

2011/2/4 Dave Reisner <d at falconindy.com>:
> On Fri, Feb 04, 2011 at 09:07:07AM -0500, Adam Weiss wrote:
>> Hey all,
> ...
>
> in openscenegraph-svn:
>> if [ $_downloadsampledata == 'True' ] ; then
>
> this is invalid syntax, as == is not a valid operator for [. makepkg
> uses bash, so please use the keyword [[ instead of the builtin [.

Just a thought: how about assigning _downloadsampledata=true (the
executable /bin/true or /bin/false) and then making the "if" even
shorter and maybe more readable:
if $_downloadsampledata; then
...
fi

- Vojta