[aur-general] Updated: cGmail

[Dave Reisner]

On Sat, Dec 15, 2012 at 03:24:21PM -0300, Lucas Saliés Brum wrote:
> Can someone point out possible errors in my package?
> https://aur.archlinux.org/packages/cgmail/
> 
> I created a patch to fix this BUG:
> https://bugs.launchpad.net/cgmail/+bug/715507
> 
> Thanks.

* patch -Np0 -i ../../cgmail.patch

Just reference "$srcdir/cgmail.patch" (with quotes) so you don't need to
worry about where you are in the source tree.

Would also be nice if you could give the patch a more useful name so as
to actually describe what it might do/fix. At minimum, add a comment.
PKGBUILDs should as much documentation as they are build recipes.

* for file in $(find....)

This is always bad and, moreover, wrong. Just use find to invoke sed.

  find . -type f -name '*.py' -exec sed -i <program> {} +

more info:
http://mywiki.wooledge.org/UsingFind
http://mywiki.wooledge.org/BashFAQ/001

* ./waf configure --prefix=/usr

Call 'python2 ./waf' instead of bothering with changing the shebangs.

d