[aur-general] [RFC] New package: proj-svn

Mateusz Loskot mateusz at loskot.net
Sat Jun 16 09:51:19 EDT 2012


On 16 June 2012 14:46, Andrew Gregory <andrew.gregory.8 at gmail.com> wrote:
>> >>  * ${srcdir}, ${pkgdir}
>> >
>> > I'm not sure I understand.
>> > Should I remove all uses of these variables?
>> > I assumed they're set implicitly when user runs makepkg -s
>>
>> Nope.  In your code, you use $srcdir.  When you should use ${srcdir}.
>> See the difference?  The braces are important: if someone uses spaces
>> in their build directory, your PKGBUILD will fail to work.
>>
>
> Braces have nothing to do with spaces in paths; they allow you to use
> variables followed by other characters that could be part of the
> variable name: ${foo}bar vs $foobar. You need to surround
> paths with quotes to protect against spaces: "$srcdir/foobar"

Thanks for clarification, I was a bit confused indeed.

Now, with all the suggested changes applied, is the proj-svn
package (created with makepkg --source) ready for submission to AUR?

Best regards,
-- 
Mateusz Loskot, http://mateusz.loskot.net


More information about the aur-general mailing list