[aur-general] TU Application - Ike Devolder

[Ike Devolder]

Op 03-03-12 16:41, Xyne schreef:
> Ike Devolder wrote:
> 
> /snip
> 
>> [1] http://aur.archlinux.org/packages.php?SeB=m&L=2&K=BlackIkeEagle
> 
> Hi Ike,
> 
> I too think that your PKGBUILDs look good. They're clean and well-structured.
> The only issue I see is the lack of variable quoting, e.g. I've seen this is
> many of them:
> 
> make DESTDIR=${pkgdir} install
> 
> That will not work if there is a space on the pkgdir path. For example:
> 
> $ mkdir 'foo bar'
> $ foo='foo bar'
> $ cd ${foo}
> bash: cd: foo: No such file or directory
> 
> 
> 
> Everything else look good. Good luck!
> 
> Regards,
> Xyne

Hi Xyne,

In general i find it a mishap building in folders containing spaces.

but because it will give a failure here i'm currently updating all my
PKGBUILDs to use the correct quoting, i'm also removing the unneeded ${}

thx for the note. In the end it is better practice

-- 
Ike

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 900 bytes
Desc: OpenPGP digital signature
URL: <http://mailman.archlinux.org/pipermail/aur-general/attachments/20120304/4c02a88b/attachment.asc>