[aur-general] please add -depth 1 to makepkg git clone

[William Giokas]

On Fri, Apr 05, 2013 at 07:35:15PM -0700, Tai-Lin Chu wrote:
> 1. you can still pull, so it will not be a reason to go against it

Okay, say that I run
  
  $ git clone --bare --depth 1 git://some.repo.git foo
  blah blah clone clone...etc.

  $ git clone foo foo-local-clone
  Cloning into 'shallowclone'...
  fatal: attempt to fetch/clone from a shallow repository
  fatal: Could not read from remote repository.

  Please make sure you have the correct access rights
  and the repository exists.

And here is what makepkg does with git sources:

1) clones a bare repository into SRCDEST
2) verifies the checksum, which should be 'SKIP' for these kinds of
   sources
3) clones the SRCDEST repo into the BUILDDIR, $srcdir.

If it can't complete this final step, then you have no sources to work
with and makepkg is worthless for git sources.


> 
> >This is also true. makepkg clones a bare repository to the SRCDEST
> >directory. If this is a shallow bare repo, then clones cannot be made of
> >it which is what makepkg does.
> 
> 2. ... i dont think why it needs to use git clone. using cp is good enough...

Using git clone preserves every file to the smallest detail. cp makes no
such guarantees. 

-- 
William Giokas | KaiSforza
GnuPG Key: 0x73CD09CF
Fingerprint: F73F 50EF BBE2 9846 8306  E6B8 6902 06D8 73CD 09CF
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://mailman.archlinux.org/pipermail/aur-general/attachments/20130405/e7a826ca/attachment.asc>