[aur-general] Merge request for php-pdf

[David Roheim]

Thanks. Updated.

David Roheim
david.roheim at gmail.com -http://roheim.org/
+972 54 3516944 - Skype: david.roheim



On Tue, Aug 13, 2013 at 6:31 PM, Felix Yan <felixonmars at gmail.com> wrote:

> On Tuesday, August 13, 2013 18:23:37 David Roheim wrote:
> > I see your point Felix. Uploaded php-pdflib so it you could merge php-pdf
> > and php-pecl-pdflib into it.
> >
> > Thanks.
> >
> > David Roheim
> > david.roheim at gmail.com -http://roheim.org/
> > +972 54 3516944 - Skype: david.roheim
> >
> >
> >
> > On Tue, Aug 13, 2013 at 5:31 PM, Felix Yan <felixonmars at gmail.com>
> wrote:
> >
> > > On Tuesday, August 13, 2013 17:26:29 David Roheim wrote:
> > > > Hi,
> > > >
> > > > Please merge php-pdf[1] into php-pecl-pdflib[2].
> > > >
> > > > [1] https://aur.archlinux.org/packages/php-pdf/
> > > > [2] https://aur.archlinux.org/packages/php-pecl-pdflib/
> > > >
> > > > Thanks.
> > >
> > > Sorry I didn't get it - the name "php-pecl-pdflib" still looks
> incorrect
> > > to me.
> > >
> > > I would suggest "php-pdflib" as the name, so it follows the same naming
> > > style as other php modules in our repos (like php-geoip, php-memcache,
> > > php-mongo, etc).
> > >
> > > If you agree, please submit a new package under the name "php-pdflib",
> and
> > > reply here so I'll merge [1] into it, and remove [2]. Thanks!
> > >
> > > Regards,
> > > Felix Yan
>
> Merged [1] into php-pdflib, removed [2], thanks!
>
> A little suggestion btw, the "|| return 1" thing is obsolete and can be
> safely removed, and you should split the phpize and make steps into
> build(), and leave installation stuff like "make install" and the last
> install command in package().
>
> Regards,
> Felix Yan