[aur-general] Request to remove/orphan the AUR package "aspell-nb"

[Limao Luo]

On 02/08/2013 09:33 PM, Third3ye wrote:
> The AUR package "aspell-nb" doesn't build, is outdated and most likely 
> abandoned. I suggest to either remove it or orphan it so that I can 
> replace the PKGBUILD with an edited version that actually builds:
>
> pkgname=aspell-nb
> _pkgname=aspell-no
> pkgver=0.50
> pkgrel=2
> pkgdesc="Norwegian Bokmål dictionary for aspell"
> url="http://aspell.net/"
> license="GPL"

Nitpicky, I know, but license is an array, and should have parentheses 
around it.

> depends=('aspell')
> arch=('i686' 'x86_64')
> source=(ftp://ftp.gnu.org/gnu/aspell/dict/nb/${_pkgname}-${pkgver}-${pkgrel}.tar.bz2) 
>
> md5sums=('b24b20ad02ce2a569f71f949b48823cc')
>
> build() {
>        cd $startdir/src/${_pkgname}-${pkgver}-${pkgrel}

Don't use $startdir, please. Use $srcdir instead of $startdir/src.

>        ./configure
>        /usr/bin/make || return 1

The "|| return 1" does nothing; makepkg will exit if any command fails 
anyway.
Also, I don't see it necessary to explicitly call /usr/bin/make, just 
make will work fine.

>        /usr/bin/make DESTDIR=$startdir/pkg install

Similar to above, $pkgdir is standard, while $startdir/pkg is obsolete.

> }
>
> Please let advise if this PKGBUILD isn't following AUR guidelines.
>
> Thank you.