[aur-general] [RFC] freeplane-git PKGBUILD

[Ivan Shapovalov]

On Thursday 07 November 2013 at 11:38:52, Leonidas wrote:
> Hello,
> 
> Just made a git version of freeplane package I maintain. Since it's one of
> my first git packages I'd appreciate a second eye / opinion. Here is the
> link:
> https://github.com/inglor/pkgbuild/tree/master/freeplane-git
> 
> Thanks
> Leonidas

Hi!

Looks pretty good; I've got a few comments here and there.

> source=('git+https://github.com/freeplane/freeplane.git' 'license.txt' 'freeplane.desktop' 'freeplane.run')

It's better to use 'git://' scheme (slightly more intelligent protocol is used).
(Note: 'git+' will be unneeded if you switch to 'git://'.)

> for file in $( find plugins -type f ) ; do

This construct is whitespace-error-prone. It's a bit better to use

    find plugins -type f | while read file; do

instead of that line.

>  # Where's the licence?
>  #install -Dm644 license.txt ${pkgdir}/usr/share/freeplane/licence.txt

I suppose you're asking for help with destination (the source is, obviously, under $srcdir).

In Arch, custom licenses shall be installed under /usr/share/licenses/$pkgname/,
but it is not needed in this package since you have specified license=('GPL').

Regards,

-- 
Ivan Shapovalov / intelfx /