[aur-general] [RFC] freeplane-git PKGBUILD

Leonidas Spyropoulos artafinde at gmail.com
Thu Nov 7 10:38:02 EST 2013

Go Ivan,

Thanks for the comments!

On 7 Nov 2013 15:21, "Ivan Shapovalov" <intelfx100 at gmail.com> wrote:
> Hi!
> Looks pretty good; I've got a few comments here and there.
> > source=('git+https://github.com/freeplane/freeplane.git' 'license.txt'
'freeplane.desktop' 'freeplane.run')
> It's better to use 'git://' scheme (slightly more intelligent protocol is
> (Note: 'git+' will be unneeded if you switch to 'git://'.)

OK I will try that
> > for file in $( find plugins -type f ) ; do
> This construct is whitespace-error-prone. It's a bit better to use
>     find plugins -type f | while read file; do
> instead of that line.
Thanks I didn't think of that. I'll use your proposal for quoting them as

> >  # Where's the licence?
> >  #install -Dm644 license.txt ${pkgdir}/usr/share/freeplane/licence.txt
> I suppose you're asking for help with destination (the source is,
obviously, under $srcdir).
> In Arch, custom licenses shall be installed under
> but it is not needed in this package since you have specified
Well kinda.. If you see the distribution packages from sourceforge there is
a licence included. When you build from source I see no licence somewhere
in the source code.  So the comment is for me to remember there is no
licence in source code. I know the package is GPL from the site so I put it
there in the licence field. I think it can go away..

> Regards,
> --
> Ivan Shapovalov / intelfx /


More information about the aur-general mailing list