[aur-general] PKGBUILD review request

[Evgeniy Alekseev]

On Friday 10 January 2014 20:35:45 Douglas Christman wrote:
> It looks like GOPATH needed to be set for it to build correctly.  Would you
> mind testing out the changes I made to see if it fixes the problem?
> 
> https://raw.github.com/dobyrch/termboy-go/master/PKGBUILD
> 
> On Fri, Jan 10, 2014 at 7:36 PM, Evgeniy Alekseev 
> <darkarcanis at mail.ru>wrote:
> > 4. It has several errors during build (could not find packages
> > github.com/dobyrch/*). I think you must fix it in the upstream =)

Yes, now it builds normally. But anyway I think that patching of source files 
in the upstream (or creating a patch that does this in the prepare() function) 
will be better way than moving of sources to the correct path. But as you 
wish. And it is recommended using a patching/moving/etc in the prepare() 
function not build() or package().
BTW instead "src/github.com/dobyrch" will be better to use "$srcdir" variable 
(e.g. "$srcdir/github.com/dobyrch").
-- 
С уважением, Е.Алексеев.
Sincerely yours, E.Alekseev.

e-mail: darkarcanis at mail.ru
ICQ: 407-398-235
Jabber: arcanis at jabber.ru
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://mailman.archlinux.org/pipermail/aur-general/attachments/20140111/f6564476/attachment.asc>