[aur-general] package review and merge request

[carstene1ns]

Am 15.01.2014 20:07, schrieb Doug Newgard:
> ----------------------------------------
>> Date: Wed, 15 Jan 2014 10:41:30 -0500
>> From: ichimonji10 at gmail.com
>> To: aur-general at archlinux.org
>> Subject: [aur-general] package review and merge request
>>
>> Could someone look over my package python2-django-extensions [1]? In
>> particular, I'm curious about a namcap warning. [2] Namcap complains that
>> python should be a dependency, because some scripts call python. However,
>> this is a python 2 package, so that warning seems nonsensical. Thoughts?
>>
>> If all seems well, could someone merge django-extensions [3] into
>> python2-django-extensions [1]? The current maintainer is OK with the merge,
>> as per comments on the AUR.
>>
>> [1] https://aur.archlinux.org/packages/python2-django-extensions/
>> [2] http://pastebin.com/5VVhHnSQ
>> [3] https://aur.archlinux.org/packages/django-extensions/
> 
> Not nonsensical, if the script calls "python", it will run with python3. If they should be python2, you need to change the shebang yourself as part of the PKGBUILD. 		 	   		  

As Doug already stated, the scripts have a python3 shebang, so you need
to change it. You can add a prepare() function like this:
https://paste.xinu.at/FprPT/bash
Please make sure the scripts are actually intended for python2, though.

Also, I don't think you need to include the LICENSE file directly, as
the tarball has the same file and you are actually copying that.

best regards,
carstene1ns

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 555 bytes
Desc: OpenPGP digital signature
URL: <http://mailman.archlinux.org/pipermail/aur-general/attachments/20140115/3ad8084c/attachment.asc>