[aur-general] PKGBUILD Critique

[Florian Bruhin]

* stef204 <stef204 at yandex.com> [2015-02-10 18:02:15 -0700]:
> Anyway, here is an updated version. 
> 
> <https://bpaste.net/show/8fdb2226c3d7>
> 
> Better?

Some more remarks:

- Is it really a good idea to check /etc/locale.conf? Wouldn't
  something like   [[ ${LANG,,} == *utf-8* ]]   be more appropriate?

  (the ,, converts it to lower-case, see
  http://wiki.bash-hackers.org/syntax/pe#case_modification )

- I'd move the 'cd' in line 32 to the top of package() and remove the
  second one in line 35, but that's just a small style issue

Flo

-- 
http://www.the-compiler.org | me at the-compiler.org (Mail/XMPP)
   GPG: 916E B0C8 FD55 A072 | http://the-compiler.org/pubkey.asc
         I love long mails! | http://email.is-not-s.ms/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <https://lists.archlinux.org/pipermail/aur-general/attachments/20150211/b7a0baac/attachment.asc>