[aur-general] package review

[Stefan Husmann]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Am 05.10.2014 um 18:35 schrieb carstene1ns:
> Am 05.10.2014 um 14:41 schrieb Thiago Barroso Perrotta:
>> I wonder why you have a test program but don't use it in the test()
>> function of your PKGBUILD? Not that this is needed, but as soon as I saw
>> 'test.c', I thought I would find a test() too.
> 
> Just a small correction: test() is no default function, the function you
> should use is check() [1].
> 
> best regards,
> carstene1ns
> 
> [1]: https://www.archlinux.org/pacman/PKGBUILD.5.html#_packaging_functions
> 
> 
And additionally: test is also a built-in function of popular shells, so running
a script or binary named "test" can be the source of strange, unexpected things
happening.


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJUvCR0AAoJEIT1NQXkgeRlq8AP/3Q4ziJL2RhKuRBOy3RztZ1b
utQHlQpC1fkPugeXKdIL2F9/c7o4aoEWpDxBGCDtR1edFpX2UpSVfy+0ocxk1F+V
EmwNfqmepbITpGrGnDngoSKLRDQoFQIjbgicRCE4C4llkJi54AM5JWmkuFcf97va
oAebrXfsAuxTLv7uPVlNDJ3PV+9zPtcucfKFPzZb7QBW3lhCab3BxAgpglggjzSS
l8kma5Wo/f+ZH4GTjx18pWUWNKbfPXlDFH+LFf1PbB/c4tdI0/qtbJoTzPtJoFpf
WJmk277CbGl0mVZtxZWB68UeIzUPqPLmI3rx9fEqGTKLm9oGzqVYileOqunFua6v
5AwhWkpnlu0oWB/6GL7QL5ZCedHZj5EVj7LFNzB5Q74vaArbp1ndvHnIu6iBfIkH
1tm1S6aBirJ+/Rmn+3WqgsJFJxbCtejIJ7jY3AA3NSv+eJretP9PlU2wF6+GjLBF
pg8NHJJjuG/2hJJ3IJ+9jj516pYwTX6ej6oNtSwjFneaPrGXMgjU/X2vgOSbLvfx
faECxhuLtbGcbNfdQgymczose97xpX3t0xfkFpZiXWdoiOdj/hfC7FDO9kS6dj1u
8tJidg8H/oI/DYuzF/kqFa2NRmEmPaTz4OjH5kAW09OPsXQLv/nypi2MHAoqlSVR
kh9bM0PyXwWABn2M40fv
=0gCk
-----END PGP SIGNATURE-----