[aur-general] PKGBUILD review request: libdime-hg

[Alessandro Menti]

Hi Eli,
I've fixed all the issues you found, the revised PKGBUILD is below.

>> depends=('gcc-libs')
> 
> gcc-libs is part of the base group, and therefore all Arch Linux systems
> are expected to have it installed. I am not sure why there are any
> packages that (seemingly unnecessarily, except in the case of e.g. gcc
> which *needs* to depend on the same ${pkgver}-${pkgrel}) depend on it,
> but surely that isn't an excuse to further clutter up the pacman
> database with unneeded dependency chains...
I did add it at first because, otherwise, if namcap is run on the created
package, it complains about the missing dependency on gcc-libs:

> libdime E: Dependency gcc-libs detected and not included (libraries ['usr/lib/libgcc_s.so.1', 'usr/lib/libstdc++.so.6'] needed in files ['usr/lib/libdime.so.1.0.0'])

Thanks again for the review,
Alessandro Menti

----- The PKGBUILD follows: --------------------------------------------
# Maintainer: Alessandro Menti <alessandro dot menti at hotmail dot it>

pkgname=libdime
pkgver=r187
_commit=7cd55bc6a6d0
pkgrel=1
pkgdesc="A DXF (Data eXchange Format) file format support library"
arch=('i686' 'x86_64')
url="https://bitbucket.org/Coin3D/dime"
license=('BSD')
makedepends=('doxygen' 'mercurial')
source=("${url}/get/${_commit}.tar.gz")
sha256sums=('23abc644771914accb47bd144ff6e533a7e6d6b6b44b588bd9ec827b236efbda')

build() {
	cd "$srcdir/Coin3D-dime-${_commit}"
	./configure --prefix=/usr --enable-html
	make
}

package() {
	cd "$srcdir/Coin3D-dime-${_commit}"
	make DESTDIR="$pkgdir/" install
	install -D -m644 COPYING "$pkgdir/usr/share/licenses/$pkgname/LICENSE"
}