[aur-general] afraiddns-git PKGBUILD: review and criticism welcome
Justin Dray
justin at dray.be
Sun Jun 5 11:20:41 UTC 2016
You can add an empty file in the package for the key, and set it in the
backup array, that way it won't overwrite existing files and will work
without doing it via a shell script and not tracking the file in pacman.
Your pkgver function should probably be below the list of static variables
at the top, not in the middle of them.
The license should be 'custom' unless it's a more standard one. See [1] for
more info on that.
If you don't use a build function, just don't include it. No point making a
no-op one in there.
Otherwise it looks good to me
[1] https://wiki.archlinux.org/index.php/PKGBUILD#license
Regards,
Justin
More information about the aur-general
mailing list