[aur-general] PKGBULD validation

[Patrick Ziegler]

Hello everyone,

This is my first mail in here and I am ready to submit my first
PKGBUILD to the AUR. But before I do that, I would like you to have a
look at it, to make sure that nothing is wrong with it. I have already
been through all the related wiki pages, namcap only complains about
unnecessary dependencies (since this is a python project, we can
ignore that) and the package seems to build and install fine on my
system.

I have two PKGBUILDs, one for the -git package and one for the normal one.
The one for the normal pacakge:
# Maintainer: Patrick Ziegler <p.ziegler96 at gmail dot com>
# Contributor: Patrick Ziegler <p.ziegler96 at gmail dot com>
pkgname="notification-mount"
pkgver=1.0.0
pkgrel=1
pkgdesc="Script to show notification for a block device with mount option"
arch=('any')
url="https://github.com/patrick96/notification-mount"
license=('GPL3')
depends=('python3' 'python-gobject' 'python-notify2' 'udevil')
makedepends=('git')
provides=('notification-mount')
conflicts=('notification-mount')
source=("${pkgname}::git+${url}.git#tag=v${pkgver}")
md5sums=("SKIP")

package() {
  cd "$srcdir/$pkgname" || exit
  install -D -m755 "./notification-mount.py"
"$pkgdir/usr/bin/notification-mount.py"
  ln -s "notification-mount.py" "$pkgdir/usr/bin/notification-mount"
  for _f in "./examples/*"
  do
    install -D -m644 $_f "$pkgdir/usr/share/$pkgname/examples/$(basename $_f)"
  done
  install -D -m644 ./examples/notification-mount.service \
    "$pkgdir/usr/lib/systemd/user/notification-mount.service"
}

# vim:set ts=2 sw=2 et:

The one for the git package:
# Maintainer: Patrick Ziegler <p.ziegler96 at gmail dot com>
# Contributor: Patrick Ziegler <p.ziegler96 at gmail dot com>
_pkgname="notification-mount"
pkgname="${_pkgname}-git"
pkgver=1.0.0
pkgrel=1
pkgdesc="Script to show notification for a block device with mount option"
arch=('any')
url="https://github.com/patrick96/notification-mount"
license=('GPL3')
depends=('python3' 'python-gobject' 'python-notify2' 'udevil')
makedepends=('git')
provides=('notification-mount')
conflicts=('notification-mount')
source=("${_pkgname}::git+${url}.git")
md5sums=("SKIP")

pkgver() {
  cd "$_pkgname" || exit
  git describe --long --tags | sed 's/^v//;s/\([^-]*-g\)/r\1/;s/-/./g'
}

package() {
  cd "$srcdir/$_pkgname" || exit
  install -D -m755 "./notification-mount.py"
"$pkgdir/usr/bin/notification-mount.py"
  ln -s "notification-mount.py" "$pkgdir/usr/bin/notification-mount"
  for _f in "./examples/*"
  do
    install -D -m644 $_f "$pkgdir/usr/share/$_pkgname/examples/$(basename $_f)"
  done
  install -D -m644 ./examples/notification-mount.service \
    "$pkgdir/usr/lib/systemd/user/notification-mount.service"
}

# vim:set ts=2 sw=2 et:

I also have a question about the example files. Currently I'm
installing them to /usr/share/notification-mount/examples, are there
default/recommended paths for those kinds of things or am I free to
choose here?

I really appreciate any feedback.

Thanks in advance,
Patrick