[aur-general] Review request for a PKGBUILD

[Bruno Pagani]

Le 08/01/2017 à 05:59, Leonid Bloch a écrit :

> pkgver() {
>     cd "${srcdir}/${pkgname%-git}"
>
> prepare() {
>     cd "${srcdir}/${pkgname%-git}"
>
> build() {
>     cd "${srcdir}/${pkgname%-git}/LZ4"
>
> package() {
>     cd "${srcdir}/${pkgname%-git}/LZ4"

Just a tiny thing, but makepkg always start each function into
"${srcdir}$", so you could remove it from these paths (and thus the
quote altogether).

>     install -D -m755 "${srcdir}/hdf5_env.sh"
> "${pkgdir}/etc/profile.d/hdf5_env.sh"

However, don’t remove it here, because you’re not in the "${srcdir}"
anymore at this point. I’m sure you know, but that’s just in case you
could have went too fast in removing ${srcdir} everywhere (I did when I
learned about makepkg and "${srcdir}"). ;)

Regards,
Bruno

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 520 bytes
Desc: OpenPGP digital signature
URL: <https://lists.archlinux.org/pipermail/aur-general/attachments/20170108/1f9cccfc/attachment.asc>