[aur-general] Review request for a PKGBUILD

[Doug Newgard]

On Sun, 8 Jan 2017 13:08:57 -0600
Doug Newgard <scimmia at archlinux.info> wrote:

> On Sun, 8 Jan 2017 20:04:26 +0100
> Martin Kühne via aur-general <aur-general at archlinux.org> wrote:
> 
> > On Sun, Jan 8, 2017 at 4:49 PM, Bruno Pagani via aur-general
> > <aur-general at archlinux.org> wrote:  
> > >>     cd "${srcdir}/${pkgname%-git}/LZ4"    
> > >
> > > Just a tiny thing, but makepkg always start each function into
> > > "${srcdir}$", so you could remove it from these paths (and thus the
> > > quote altogether).    
> > 
> > Bash gurus recommend keeping the quotes, as ${pkgname%-git} is also a
> > parameter, and we generally encourage those be quoted.
> > 
> > cheers!
> > mar77i  
> 
> $pkgname is controlled by the PKGBUILD and is guaranteed to to contain spaces.
> Quotes wouldn't be needed.

Crap, that should be "not to contain", rather than "to to contain"