[aur-general] Package review bitcoin-classic

[Tom Zander]

On Wednesday, 11 January 2017 09:19:45 CET Doug Newgard wrote:
> I'm not talking about the package function, I'm talking about the .install
> file with the post_{install,upgrade,remove} scriptlets. Specifically:

My apologies, I must have misread :)

I have to ask a bit more since your pointers are great, but I’m not sure how 
I can actually accomplish them: 

> Disabling COW should be left up to the sysadmin.

How would we do that?

> chown should be done in the PKGBUILD if at all possible

Can you explain how? AFAICT the user doesn’t exist yet at that point.

> Users should not be deleted; this is a security issue if the UID gets
> reused. Your big fancy message shouldn't be there. This is normal stuff.


> The whole "/etc/bitcoin/bitcoin.conf.dist" thing shouldn't happen. Just
> install to /etc/bitcoin/bitcoin.conf in the package function.

I have not found out how pacman treats config files on upgrades, removes and 
reinstalls.
The point here is that the config file should not be overwritten by the 
package version on upgrade, it should not be deleted when the package is 
deleted (and may be reinstalled just minutes later) etc.
Only when its 100% identical to the one in the package can it safely be 
deleted / upgraded.

Maybe I didn’t look good enough, but I could not find out how to do the 
above. So I went for the safest solution.

-- 
Tom Zander
Blog: https://zander.github.io
Vlog: https://vimeo.com/channels/tomscryptochannel