[aur-general] [review-request] python-intelhex

[Quentin Bourgeois]

Hi,

I am currently looking for building python2-intelhex[0] from
AUR. Unfortunately the build failed, while I am using aursync[1] and
require build into a clean (created for this build) chroot:

$ aursync -c python2-intelhex 
[...]
==> Starting package_python-intelhex()...
/startdir/PKGBUILD: line 17: python: command not found
==> ERROR: A failure occurred in package_python-intelhex().
    Aborting...
==> ERROR: Build failed, check /var/lib/aurbuild/x86_64/user/build

Note that with the python3 package version I come up with the same
bug. 
Thus, I decide to have a look at the PKGBUILD and suggest some
modifications I guess the maintainer will be glad to merge any
proposal, but did the community see any thing more to change ?
Basically I made use a lot more of its internal variable __pkgname,
define python{,2}-setuptools as makedepends and add the license file
to the package.

In another way I don't really understand the rm on the bin directory?
The problem I saw is that only installing python2-intelhex wont allow
the use of the provided scripts[2]. However, I conducted small
tests and they seems to works even with python2. So my guess is to
create an other AUR PKGBUILD that will perform pretty the same things
but only packaging the provided scripts, let call this package
python-intelhex-scripts. Then, one need to enforce a dependencies of
python{,2}-intelhex with python-intelhex-script at the same upstream
release version.

I propose some modification in the python-intelhex[3] PKGBUILD and a
new PKGBUILD for python-intelhex-scripts[4].

What do you think ?

Thanks in advance for your feedback!

[0] https://aur.archlinux.org/packages/python2-intelhex/
[1] https://github.com/AladW/aurutils
[2] https://github.com/bialix/intelhex/tree/master/scripts
[3] https://git.bourgeois.eu/aur_python_intelhex.git/tree/PKGBUILD?id=e6187787c3743e63c5830f78dd18d58f5bc40f79
[4] https://git.bourgeois.eu/aur_python_intelhex_scripts.git/tree/PKGBUILD?id=b346e34509a53cd0ed094f686f635d7e3873a372
-------------- next part --------------
# Maintainer: Quentin Bourgeois <quentin+archlinux at bourgeois.eu>

__reponame='intelhex'
__pkgname="${__reponame}-scripts"
__license_filename='LICENSE.txt'
pkgname=("python-${__pkgname}")
pkgver=2.1
pkgrel=1
pkgdesc='Python IntelHex scripts'
url="https://github.com/bialix/${__reponame}"
optdepends=()
license=('BSD')
arch=('any')
source=("${__pkgname}-${pkgver}.tar.gz::${url}/archive/${pkgver}.tar.gz")
sha512sums=('af5ee3cb7424d15cf259861dcedf6ca68ecfae0819cb9f5c3437a1c8ff8c2f03486dd9f12b93564a5e2f4b7bab4c055a44c6dbe2a86007165412336bd2a4554f')
makedepends=('python-setuptools'
             'python2-setuptools')

check() {
    cd "${srcdir}/${__reponame}-${pkgver}"

    msg "Running tests"
    python setup.py test -q
}

package_python-intelhex-scripts() {
    depends=('python' 'python-setuptools')

    cd "${srcdir}/${__reponame}-${pkgver}"

    python setup.py install --root="${pkgdir}" --optimize=1
    install -Dm644 "$__license_filename" "${pkgdir}/usr/share/licenses/${pkgname}/LICENSE"

    rm -rf "${pkgdir}/usr/lib/"
    rm -rf "${pkgdir}/usr/share/"
}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.archlinux.org/pipermail/aur-general/attachments/20170124/dd411d5f/attachment.asc>